Closed loliver closed 2 years ago
Had some time tonight to dig in to the Cypress test failures, base64-url
is still expecting Buffer
from node to exist by default so I've added a plugin that polyfills Webpack 5 as per the older versions.
Can somebody from maintainers please take a look at this PR? @markdalgleish @michaeltaranto @mattcompiles
Hey 👋,
Sorry we haven't had bandwidth to look into this. Our main concern here is maintaining compatibility with webpack 4 as a lot of consumers are still using it. Not sure how difficult it would be to support both but otherwise we'll need to do a breaking change.
Also there are a lot of changes in this PR that seem unrelated to webpack 5 which makes it a bit hard to review.
Thanks all! :tada:
Working towards a fix for #215.
Our stack is React 17 with Treat, with our docs running on Gatsby.
The error I'm stuck on is getting pulled up in each imported component:
As well as the following which I'm pretty sure are just based on the Webpack builds failing per compnent:
Have published a smurf package to
loliver-test-playroom
as I was getting issues with multiple Webpack installs.Hoping there are others out there that this can help and we can get to a solution.
Cheers.