search

seek-oss / playroom

Design with JSX, powered by your own component library.
MIT License
4.45k stars 183 forks source link

chore: Updating dependencies for npm vulnerability #227

Closed caseymhunt closed 2 years ago

caseymhunt commented 3 years ago

This change updates two dependencies: mini-css-extract-plugin and style-loader.

According to an npm audit vulnerability warning, mini-css-extract-plugin depends on a vulnerable version of normalize-url. This package was updated to a version that no longer depends upon normalize-url (1.1.0) and per the 1.0.0 recommendations, style-loader was upgraded to 2.0.0.

Vulnerability warning in question:

npm vulnerability 1755

References:

caseymhunt commented 3 years ago

I have checked for loss of functionality to the best of my ability. I am relying on the owner to do a full audit to ensure there are no breaking changes introduced.

caseymhunt commented 3 years ago

Any chance I can get this reviewed / considered?

michaeltaranto commented 2 years ago

Resolved by https://github.com/seek-oss/playroom/pull/218