Open TheMightyPenguin opened 1 year ago
Latest commit: ff0ab35a3304a1b6d59436fc4667fba03be882c8
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@michaeltaranto this is ready for review! ran cypress tests locally and they are passing
@michaeltaranto @askoufis any updates here? 👀 I just rebased the PR as it had some conflicts
@michaeltaranto @askoufis following up here!
@askoufis would you elaborate more on this plugin idea? (I am guessing it means there would be a plugin system and there would be webpack, vite plugins and so on)
Also thanks for the review! gonna get to attending it this weekend!
@askoufis would you elaborate more on this plugin idea? (I am guessing it means there would be a plugin system and there would be webpack, vite plugins and so on)
Also thanks for the review! gonna get to attending it this weekend!
Yeah something like that. Basically, rather than playroom being a CLI that spins up a dev server, it would be a plugin that would integrate with bundlers like webpack and vite, using their dev servers to host the playroom site.
@askoufis love that idea, agree on getting this in as a temporary solution and I'd love to get more involved in that 👀
@askoufis attended comments! still need to do some more testing, will also add the viteConfig
key to the vite fixture, but other changes should remain mostly the same now
Thanks very much @TheMightyPenguin ! I was trying to find some prior art for playroom config with tailwindcss/postcss support, unfortunately the projects I found were out of date or I simply couldn’t get it working with the same/like configuration. But I pointed to your branch and worked right out of the box! :tada: :heart:
Description
Adds vite support. The motivation here:
Changes mode.
This is a chunky PR (sorry about that), here's an overview of the changes:
bundler
option to playroom config. This option is required, and should be either'vite'
or'webpack'
.viteConfig
option to playroom config. This is a function that returns the user Vite configuration.