Closed nib-bturner closed 8 months ago
Latest commit: 4508c0acce9f0a8331491e0705e08af95d20dce7
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Hi @askoufis, I noticed you're the most recent reviewer on this project. Is there any chance you can have a look over this feature request?
Thanks 🙏🏼
Looks like the eslint config needs to be tweaked, but then this should be good to go.
As a consumer, I want to be able to define my playroom config using ESM compatible JS code. I noticed today when trying this behaviour out that sadly playroom does not currently support this, so I've prepared this PR to add support for this behaviour.
As this PR replaces
require
withimport
for loading config files, it is important that thebin/cli.js
file is still loaded as CommonJS code. To force this behaviour (when users might specify"type":"module"
in theirpackage.json
s) I have renamed itbin/cli.cjs
.Unsure if this is best released as a minor or major change. I can modify the changeset command as needed.