Unable to build playroom without a favicon

seek-oss / playroom

Design with JSX, powered by your own component library.

MIT License

4.48k stars 182 forks source link

Unable to build playroom without a favicon #311

Closed jordanoverbye closed 8 months ago

jordanoverbye commented 9 months ago

I'm unable to run playroom build after upgrading to 0.34.1. I'm getting the following error:

Error: HtmlWebpackPlugin: could not load file /path/to/repo/images/favicon.png
- index.js:494      [repo]/[html-webpack-plugin]/index.js:494:35     error Command failed with exit code 1.

This seems to have been caused by PR #309

If I create a images/favicon.png file everything works correctly, but this seems unexpected for a patch release.

mrm007 commented 8 months ago

@jordanoverbye does this snapshot work for you?