Fix `playroom build` by making favicon path relative to webpack config

seek-oss / playroom

Design with JSX, powered by your own component library.

MIT License

4.48k stars 182 forks source link

Fix `playroom build` by making favicon path relative to webpack config #314

Closed askoufis closed 8 months ago

askoufis commented 8 months ago

https://github.com/seek-oss/playroom/pull/309 seems to have broken playroom build. This wasn't caught during CI as the preview build runs a script from the repo root, so the path resolves correctly. However it's incorrect in any other case, e.g. using playroom as a dependency.

Have confirmed that this fix works by testing Braid's playroom build.

Ideally we'd have proper fixtures (i.e. make the repo into a monorepo) that we could test in isolation, but we're not there yet.

Fixes #311.

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: 139fb1f37efa0d2b5222eb84ac0873f5a6432fad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------- | ----- | | playroom | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR