search

seek-oss / playroom

Design with JSX, powered by your own component library.
MIT License
4.45k stars 183 forks source link

Playroom favicon is not customizable #320

Closed marcoskolodny closed 1 month ago

marcoskolodny commented 4 months ago

Hello!

I was trying to add a custom favicon to my Playroom website, but I couldn't make it work. After digging into the code, I've noticed that in this PR you are forcing the icon to be the playroom logo.

I believe the playroom logo is nice to have, but the favicon should be customizable. I fully agree with this comment in the PR. Why not allowing users to pass their own favicon through playroomConfig or through the public folder, and using the playroom logo as fallback if the user didn't pass one?

felixhabib commented 1 month ago

Thanks for the request!

Currently we don't see the value in offering a custom favicon, as the current favicon helps distinguish Playroom tabs from other browser tabs. It does not seem worth the API complexity to add this feature.

If we see a valid use for this feature, we will look to revisit this.