search

seek-oss / playroom

Design with JSX, powered by your own component library.
MIT License
4.45k stars 183 forks source link

Fix async import of playroom config on Windows #338

Closed askoufis closed 4 months ago

askoufis commented 4 months ago

Fixes #307.

When working with windows paths, a path like C:\foo\bar will be misinterpreted by import. It interprets the path as a URL and thinks C: is a protocol. url.pathToFileURL addresses this by converting the path to a proper file URL, which import interprets correctly.

Verified the fix on my Windows machine.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 577928d5c0b7f2b7eb37454d807180385af2e79f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | playroom | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR