seek-oss / playroom

Design with JSX, powered by your own component library.
MIT License
4.48k stars 182 forks source link

Fix reliability issues in Cypress tests for search related keyboard shortcuts #345

Closed felixhabib closed 6 months ago

felixhabib commented 6 months ago

Currently, Cypress tests in CI are unreliable and will only pass a slim majority of the time. This change adds some more time for new search-related shortcut tests to ensure Playroom has settled after shortcuts are triggered. This branch has passed Cypress in CI over 10 times and is proving more reliable.

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: 666b1e8cd74773e73f0496b7fbc9755dbc6be4a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR