search

seek-oss / playroom

Design with JSX, powered by your own component library.
MIT License
4.45k stars 183 forks source link

Fix centering of settings panel and toolbar icons #354

Closed askoufis closed 1 month ago

askoufis commented 1 month ago

The element wrapping these icons wasn't really doing anything, other than causing the icons to be laid out in flow layout, resulting in extra bottom padding because of line height. Rather than setting line-height: 0 on the wrapping elements, I just removed them so the icons are now using flex, so they don't end up with the line height padding.

Before:

before 1 before 2

After:

after 1 after 2
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 43be0341c6c0d91e7f569bfc603116b372019569

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | playroom | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR