seek-oss / sku

Front-end development toolkit
https://seek-oss.github.io/sku
MIT License
479 stars 35 forks source link

Fix default compile package detection in PNPM repos #975

Closed askoufis closed 5 months ago

askoufis commented 5 months ago

Using withSymlinks always resolves to an absolute path. However, in combination with withRelativePaths, fdir thinks it's dealing with a relative path, but it's actually absolute, so it ends up removing part of the start of the path, resulting in an error.

In hindsight, it's much simpler to just use absolute paths everywhere, rather than joining paths ourselves.

Not exactly sure how this slipped through when I was testing the fdir refactor, but I don't think the effort required to setup a unit test for this functionality is worth it.

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: fb022a68c79f32aa22f939d36813fe0b170b7cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---- | ----- | | sku | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR