search

seek-oss / sku

Front-end development toolkit
https://seek-oss.github.io/sku
MIT License
479 stars 35 forks source link

Test storybook iframe URL directly, remove storybook test util #995

Closed askoufis closed 5 months ago

askoufis commented 5 months ago

I couldn't figure out how to completely remove the need to interact with the storybook UI in #988 because when serving a built storybook, navigating to /iframe.html didn't seem to work. Turns out it was the asset server's fault, and simply configuring cleanUrls is all that's required to make the /iframe.html path work.

Technically, /iframe works just fine, but by configuring the server this way we don't need two different paths, one for testing against the storybook dev server, and another for testing the built storybook.

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 1c57e99b405a9872f8aa36b627882e7924661a2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR