sku v13: Remove storybook dependencies, CLI and automatic configuration

askoufis commented 5 months ago

Changes

Sku no longer provides the following Storybook-related features:

Installation of Storybook dependencies
Storybook CLI commands (sku storybook and sku build-storybook)
Automatic configuration of .storybook/main.ts
Re-exporting of storybook APIs under sku/@storybook/react

Users are now expected to install and configure Storybook themselves. sku provides some minimal configuration via the sku/config/storybook entrypoint.

Reasoning

There's an internal document with a more thorough writeup, but a non-exhaustive summary would be:

Decoupling the sku version from the storybook version allows consumers to upgrade when they're ready
Storybook is a large dependency, and roughly 75% of sku consumers don't use it, so why should they install it?
Sku's CLI wrappers weren't providing much value, and the automatic configuration was restrictive, and we can still provide useful config without being prescriptive
We don't really have any opinions on how you should use storybook, so why should we restrict how you configure it?

Reviewer notes

A lot of changed files are just *ignore file updates.

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 3b60a8c83b762bd0ee568cfa139ac643474976a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ---- | ----- | | sku | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tadhglewis commented 4 months ago

@askoufis I reckon this makes sense and honestly makes it easier for consumers - there's not many SB users, exposing storybook within sku is annoying for updates (e.g. exposing preview.tsx config you had to change for our panels repo etc)

askoufis commented 4 months ago

@askoufis I reckon this makes sense and honestly makes it easier for consumers - there's not many SB users, exposing storybook within sku is annoying for updates (e.g. exposing preview.tsx config you had to change for our panels repo etc)

@tadhglewis Have added a reasoning section to the PR just to call this out. Didn't want it to seem like a sudden decision, there was a decent amount of though put into this.

As per your original comment, would be happy to cut a snapshot release if you want to test it out.

askoufis commented 4 months ago

@tadhglewis

"sku": "0.0.0-remove-storybook-deps-config-cli-20240617001049",

seek-oss / sku