Closed askoufis closed 2 months ago
Latest commit: 102bb7983073a0b0b5eba2088f53810361befa12
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This is pre-work to removing support for
.less
styles in sku v13. To prevent a huge PR, I've split up feature removal (will be in a follow up PR) from the style conversion/test updates (this PR).The changes should be fairly straightforward. Basically just converted all less styles in fixtures to VE styles, and updated tests accordingly. The
react-css-modules
fixture was doing a subset of the tests that thetypescript-css-modules
fixture already does, so I removed the entire fixture.There's potentially some more redundant tests/fixtures we could clean up, and we should ideally rename
typescript-css-modules
to something liketypescript-vanilla-extract
, but I didn't want to bloat the PR too much, so I'll probably get to that stuff post-v13 release.