search

seek-oss / skuba

🤿 SEEK development toolkit for backend applications and packages
https://seek-oss.github.io/skuba/
MIT License
60 stars 33 forks source link

Explicitly declare return types #1589

Closed samchungy closed 4 months ago

samchungy commented 4 months ago

Resolves https://github.com/seek-oss/skuba/issues/1563

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 0c1321d29c5d7242498703ab2eddb17459f63688

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

samchungy commented 4 months ago

I don't really understand the need for this but seems fine

something something esm/cjs cranky. We could create multiple declaration files but it's a bit of a mess.

samchungy commented 4 months ago

I don't really understand the need for this but seems fine

We ultimately should be exporting different types for cjs, and esm:

image

But because we're only shipping one, the TypeScript compiler is going why are you trying to import in my cjs world.