search

seek-oss / skuba

🤿 SEEK development toolkit for backend applications and packages
https://seek-oss.github.io/skuba/
MIT License
60 stars 32 forks source link

RFC: Do not modify config files if version is outdated #1604

Open 72636c opened 2 months ago

72636c commented 2 months ago

I noticed some recent commits where config file changes were going back and forth. However, after writing this I'm not sure that it is actually worth it, given e.g. a Prettier change between versions would similarly cause such churn if local dependencies are outdated. Thoughts?

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 4c40dce06357a80be9ee92631afd279a40c828da

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tadhglewis commented 2 months ago

Thx for the QoL fix! It's definitely not ideal if skuba formats in CI but gets overwritten by the dev again

AaronMoat commented 2 months ago

Wonder if global skuba should delegate to local skuba if it can find it 🤔

Edit: or is this a problem of not having installed deps?

tadhglewis commented 2 months ago

@AaronMoat

Scenario

  1. Dev pulls master and does pnpm format
  2. Dev pushes
  3. Skuba formats due to dev format using out of date skuba
  4. Dev pulls and then re-pushes their bad format

Repeat

AaronMoat commented 2 months ago

I actually think it could warrant a log 🤷