seek-oss / skuba

🤿 SEEK development toolkit for backend applications and packages
https://seek-oss.github.io/skuba/
MIT License
60 stars 32 forks source link

template/koa-rest-api: Remove `not.toBe(404)`s #1606

Closed 72636c closed 2 months ago

72636c commented 2 months ago

These are super dodgy because they often go unloved as an API evolves and end up sending real outbound requests to upstreams when you run the test suite. Typically the upstreams don't respond with a 404 so the tests still pass, but it's gross.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: b62c60a59954d83be25f7945e67df5384200d763

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR