search

seek-oss / skuba

🤿 SEEK development toolkit for backend applications and packages
https://seek-oss.github.io/skuba/
MIT License
60 stars 32 forks source link

Fix pnpm guide #1608

Closed samchungy closed 2 months ago

samchungy commented 2 months ago

Turns out this is required. Oops. We removed it in another repo due to a different change

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 9776b2e09757a975d45cf6730d006827e78c529a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

samchungy commented 2 months ago

is this for the nested package jsons? Should we be mounting them individually not the whole contents?

It's actually everything right now. We need the built contents of the package, so at the moment we're just copying the whole dir including the lib folders and TypeScript files right now. I want to move to copying only a packed version of the package into the deployment but that will be post moving to pnpm.