search

seek-oss / skuba

🤿 SEEK development toolkit for backend applications and packages
https://seek-oss.github.io/skuba/
MIT License
60 stars 32 forks source link

Add cdk.context.json to the base gitignore #1613

Closed phillip-le closed 1 month ago

phillip-le commented 1 month ago

cdk.context.json is usually created when running cdk commands locally like:

cdk deploy

This file doesn't need to be checked because it gets generated on demand anyway and isn't required for builds.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 9e5168824a24308752428df63655d07684cd9f5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

AaronMoat commented 1 month ago

Channeling @72636c, it might make sense to put this earlier on in the gitignore list next to the other cdk items

phillip-le commented 1 month ago

Channeling @72636c, it might make sense to put this earlier on in the gitignore list next to the other cdk items

Good to put it right under cdk.out/? Was thinking of putting it there but all those ones are folders 👀

AaronMoat commented 1 month ago

Yeah I reckon

AaronMoat commented 1 month ago

Looks like AWS SDK have messed up types for no-DOM environments, going to merge this and hope it self-resolves as it's unrelated 🤞