seek4science / seek

For finding, sharing and exchanging Data, Models, Simulations and Processes in Science.
http://www.seek4science.org
BSD 3-Clause "New" or "Revised" License
77 stars 52 forks source link

CV title #1147

Open floradanna opened 2 years ago

floradanna commented 2 years ago

Describe the bug When creating a new sample_controlled_vocabs (in both Template and Sample Type), if I give an existing CV title SEEK gives warning error, since CV titles must be unique and no duplicates are allowed. However, if I look at the list of existing CV titles I see many duplicates (e.g., library source is listed 4 times at least).

To Reproduce See screenshot below and then:

  1. Go to Create --> Template or Sample type
  2. Click on Attribute Type --> Controlled Vocabulary or Ontology --> use dropdown to see the existing ones
  3. Scroll down and see titles such as "library source" listed multiple times.

This is in contrast with the following error:

Screenshot 2022-08-04 at 14 11 11

Expected behavior Consistent behaviour, although I don't know yet what that would be. To be discussed.

Desktop (please complete the following information):

Additional context In DataHub, the same attribute (like, library source) with the same CV list (titled library source as well) will be "used" many many times by derived templates (via Create Template based on existing templates) and derived sample types (via applying the same template to many studies or assays). So, I think this is what it is causing having repeated CV list titles in the dropdown menu. However, this is in contrast with default SEEK rule that prohibits having repetition of the same title in CV list.

Questions:

floradanna commented 2 years ago

@rabuono something to figure out

floradanna commented 1 year ago
kdp-cloud commented 4 months ago

Requirements: https://docs.google.com/document/d/1h_LEL8keDyKrnUJRVyuZUjE-xSRap1_yf9xDTkrJKGc/edit