search

seek4science / seek

For finding, sharing and exchanging Data, Models, Simulations and Processes in Science.
http://www.seek4science.org
BSD 3-Clause "New" or "Revised" License
75 stars 52 forks source link

`workflows/submit` endpoint marks workflows as 'updated' (triggering emails) when workflows have not been updated. #1957

Open hexylena opened 1 month ago

hexylena commented 1 month ago

Howdy, now that we're using the fantastic new /workflows/submit endpoint on dev, I noticed that I'm getting a lot more emails than I expect to from WFH.

I see hundreds of workflows marked as "updated", but then if I visit that workflow's page, there's no update. E.g. https://dev.workflowhub.eu/workflows/1060, the first listed workflow shows the following:

Views: 38 Downloads: 12 Created: 25th Jun 2024 at 10:53 Last updated: 25th Jun 2024 at 10:53 Last updated by: Helena Rasche

but the email reports otherwise:

Resources Updated:
Team Names  Resource Type   Resource Name   Person  Date Updated    Unsubscribe?
Galaxy Training Network     Workflow    Workflow 3: Classification [Galaxy Training: 16S Microbial Analysis With Mothur]    Helena Rasche   14th Jul 2024 at 14:10  Unsubscribe
Galaxy Training Network     Workflow    MSI Workflow: spatial distribution  Helena Rasche   14th Jul 2024 at 14:10  Unsubscribe
Galaxy Training Network     Workflow    Mapping And Molecular Identification Of Phenotype Causing Mutations     Helena Rasche   14th Jul 2024 at 14:29  Unsubscribe
Galaxy Training Network     Workflow    Workflow constructed from history 'Hsp90-MDAnalysis'    Helena Rasche   14th Jul 2024 at 14:10  Unsubscribe
Galaxy Training Network     Workflow    Training: 16S rRNA Analysis with Nanopore Sequencing Reads  Helena Rasche   14th Jul 2024 at 14:10  Unsubscribe
Galaxy Training Network     Workflow    Workflow Constructed From History 'imported: testpourGCC'   Helena Rasche   14th Jul 2024 at 14:10  Unsubscribe

I suspect they're getting marked as updated due to the re-upload of the ro-crate zip, but since there's no actual update the UI doesn't display anything, but the email is triggered anyway.

Please let me know if y'all need any debugging information, I'm happy to forward the email.

fbacall commented 1 month ago

Did you implement the step to update the policy after submission? If so, I think that is probably what is triggering the update notifications (although I guess it should not notify if no actual changes were made).

hexylena commented 1 month ago

Ahhh yes, we did! Good thinking.

I can try and change that to diffing the policy a bit. Thanks for the tip!