seekers-dev / seekers-java

A Java server for the Seekers game.
GNU General Public License v3.0
0 stars 0 forks source link

Use `seeker.thrust`, not `physical.max_speed` #38

Closed Belissimo-T closed 1 year ago

Belissimo-T commented 1 year ago

The config should be seeker.thrust, not physical.thrust.

Kiyotoko commented 1 year ago
private double thrust = SeekerProperties.getDefault().getPhysicalThrust();

This is in physical. Thrust effects Goals and Seekers. Thats the reason why I put it in Physical instead of Seeker.

Belissimo-T commented 1 year ago

@karl-zschiebsch To my knowledge, only seekers can accelerate und thus only seekers are affected by this config. How and when do goals need/use thrust?

Kiyotoko commented 1 year ago

Ok, then I will change that.

Kiyotoko commented 1 year ago

I have looked a bit into it. Goals are affected by thrust and can accelerate:

setVelocity(getVelocity().add(getAcceleration().multiply(getThrust() * deltaT)));

Then I will not change this.

Belissimo-T commented 1 year ago

@karl-zschiebsch Goals, however, always have a thrust of 0. Did you ever see a goal that was accelerating on its own?

Belissimo-T commented 1 year ago

fixed in 0e2c177.