search

seekshiva / courses

http://courseshub.in
GNU General Public License v3.0
5 stars 3 forks source link

/subscriptions returns stale terms #88

Closed seekshiva closed 10 years ago

seekshiva commented 10 years ago

/subscriptions returns all terms the student is attending, including the ones that are not current?

Will non-current cubscription terms be needed anywhere?

nobelium commented 10 years ago

Yes, in profile page a list of terms that the student attended uses it.

seekshiva commented 10 years ago

Can we make it so that stale terms get sent to client only when user explicitly requests for it via a GET param?

GET /subscriptions/?old=true

or something like that?

It might not affect the app right now, but four years down the line, when the current first years request for any page, /subscriptions will return a lot of data that isn't necessary for most pages, except for profile and couple of other pages.

nobelium commented 10 years ago

Can we do this after lauching?

seekshiva commented 10 years ago

Yeah yeah..

This isn't MVP. Its something that needs to be done within a year or so after launch.

seekshiva commented 10 years ago

Closing this now. We'll reopen it later when required.