size prop added to fix size issue in Android

seekshiva / react-native-remote-svg

Adds support for loading svg images in React Native

MIT License

184 stars 71 forks source link

size prop added to fix size issue in Android #4

Closed priyanka52789 closed 6 years ago

priyanka52789 commented 6 years ago

SVG images were not showing with the expected size given in style for Android.

seekshiva commented 6 years ago

Setting scalesPageToFit to true seemed to fix the scaling issue in android: https://github.com/seekshiva/react-native-remote-svg/commit/9a9c821e2401972b8a216de2219ebb5494981bb2

I just published v1.1.0 of the package right now. Can you take a look and see if you still face the issue in android?

seekshiva commented 6 years ago

@priyanka52789 the issue you mentioned was fixed in v1.1.0. Feel free to open an issue in the repo if you face any issues.

As I can see from your 3 commits, there is nothing much else that I can borrow from your code into the library, so I'll be closing this PR. Please open a new PR if you have some other changes that you want to merge in.

Thanks