Pass all props to webview

seekshiva / react-native-remote-svg

Adds support for loading svg images in React Native

MIT License

184 stars 71 forks source link

Pass all props to webview #52

Open robwalkerco opened 4 years ago

robwalkerco commented 4 years ago

Pass all props to the WebView before setting the specific WebView props required by react-native-remote-svg.

The baseUrl added to the source prop fixed an issue where iOS does not fire the onLoad... events. This also means that the calls to onLoadStart and 'onLoadEnd' can be removed, as they will be delegated to the WebView.

robwalkerco commented 4 years ago

Details of the onLoad... issue on iOS are available at https://github.com/facebook/react-native/issues/18802#issuecomment-401764616