search

seelengxd / pe

0 stars 0 forks source link

Bug: possible to pick clashing tutorial slots #3

Open seelengxd opened 1 year ago

seelengxd commented 1 year ago

image.png

  1. pick gess1025 s1
  2. pick gess1025 tut d13
  3. add cs1101s s1
  4. pick cs1101s tut 06e
soc-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Application does not check if user has picked the lesson slots that have conflicts in timing

Steps to reproduce:

add cs2030 s1

add cs2040 s1

pick cs2030 lab 10d

pick cs2040 lab 2a

Expected: Application to warn user that there is a conflict in timing.

Actual: The app allows the user to pick both timings, even though they clash.

The user guide should warn the user that the onus is on the user to check for clashes in lesson timings.

image.png

[original: nus-cs2103-AY2223S1/pe-interim#5036] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This seems like a suggestion for our feature instead of a bug because our UG only mentioned that you can pick tutorial slots and add modules, but nothing about checking whether the tutorial slots clash with each other.

We reject this suggestion because some people might choose to add in all potential lesson timings they want when planning for modules to take and timetable management. Hence, we decide to put down the feature of allowing users to put classes/tutorials at the same time. Furthermore, we have never mentioned the feature of checking for timetable clashes in our user guide or user story.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement:

Reason this is a valid type.FeatureFlaw

image.png

The user is using this for module planning, so not detecting clashes is very inconvenient for the user. Imagine the user has planned their modules, and then they do not know there is a lecture clash, and they find out on the day of ModReg! :-(

Reasons the User cannot detect a clash

  1. User guide does not mention this limitation at all.

  2. Consider the NUSMods timetable planner - lecture/tutorial slots are grouped together based on the time, so it is easy to detect clashes. On the other hand, this application groups it by modules, in plain text, so if the modules are far apart - the user cannot even see the clashing timeslots on the screen at the same time. This is further supported by the fact that fullscreen on a laptop - the application can barely fit 4 modules, let alone the typical 5 a student takes (not even considering overloading yet!)

    image.png

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]