Version 0.1.1a2 does not work with 2017-18

seemethere / nba_py

Python client for NBA statistics located at stats.nba.com

BSD 3-Clause "New" or "Revised" License

1.05k stars 255 forks source link

Open jethrolam opened 6 years ago

jethrolam commented 6 years ago

The version 0.1.1a2, which is on PyPi, does not work with 2017-18 because of the hardcoded line:

CURRENT_SEASON = '2016-17'

The master branch have this fixed... wondering the fix will be pushed to PyPi?

rneu31 commented 6 years ago

How are you using this library? That is just set as the default. You can pass your own season to each method.

season = '2017-18'

pid = player.get_player(first_name, last_name, season=season, just_id=1

game_logs = PlayerGameLogs(player_nba_com_id, season=season).info()