fixed oob auth data and authentication requirements

seemoo-lab / h4bcm_wireshark_dissector

Wireshark dissector for Broadcom specific H4 diagnostic commands

GNU General Public License v2.0

23 stars 12 forks source link

fixed oob auth data and authentication requirements #2

Closed Matheus-Garbelini closed 3 years ago

Matheus-Garbelini commented 4 years ago

authreqs - removed mask
oobauthdata - removed mask

Hi @jiska2342 is there a reason why the authentication requirement and oob auth. data was masked in the Wireshark dissector? I was only able to get the correct fields from my device (nexus5) after clearing the masks from those fields. The standard seems to indicate they are an entire octet, so no mask would be needed.

Here's the result after the fix (The 0x03 was not dissected before as the mask was 0xf0):

jiska2342 commented 3 years ago

Thanks for the fix :) Sorry for taking so long to merge this.