search

seemoo-lab / h4bcm_wireshark_dissector

Wireshark dissector for Broadcom specific H4 diagnostic commands
GNU General Public License v2.0
23 stars 12 forks source link

Installation instructions not working, possibly out of date? #3

Open KamicDemon opened 2 years ago

KamicDemon commented 2 years ago

Hello, thanks as always for the great work.

I'm trying to install InternalBlue and the H4BCM dissector on my machine. InternalBlue seems to work fine, but I'm not having a lot of luck with the H4BCM dissector.

uname -a output: Linux Avenger 5.7.0-kali1-amd64 #1 SMP Debian 5.7.6-1kali2 (2020-07-01) x86_64 GNU/Linux wireshark --version output: Wireshark 3.4.8 (Git v3.4.8 packaged as 3.4.8-1)

When running Cmake I encounter a warning stating that "include cannot find WiresharkPlugin" H4bcmpluginerror

It may also be worth noting that wireshark's plugin directory on two of my machines (Both Debian) is not in ~/.local/lib/wireshark/plugins and is instead found in /usr/lib/x86_64-linux-gnu/wireshark/plugins.

My intuition is to blame wireshark's weird directory structure, but I would appreciate some advice. Thank you!

cryptoluks commented 2 years ago

Try https://github.com/seemoo-lab/h4bcm_wireshark_dissector/pull/4.

DenofTranquility commented 2 years ago

I am having this exact same problem... I have also used the new CMakeLists.txt as suggested. I have up to date Wireshark and Cmake

  Wireshark 3.4 libraries not found, performing an in-tree Wireshark plug-in build.
  CMake Error at CMakeLists.txt:49 (include):
    include could not find requested file:

      WiresharkPlugin

  CMake Error at CMakeLists.txt:52 (set_module_info):
    Unknown CMake command "set_module_info".

Is there a way I can help it find Wireshark? I've never used Cmake before so it's operation is a mystery to me

DenofTranquility commented 2 years ago

I managed to get everything working. I used #4 as suggested above.

When I initially tried it I only changed the CmakeLists.txt file, this time I copied everything over and changed all the files and now it's working. I guess I was having a day of lunacy :/

I did try setting the DESTDIR variable to the wireshark plugins folder but that didn't change anything. I had to hardcode the location in the CMakeLists.txt file.

BJamin99 commented 2 years ago

4 has been merged. Perhaps this issue is now resolved?