search

seemoo-lab / opendrop

An open Apple AirDrop implementation written in Python
https://owlink.org
GNU General Public License v3.0
8.49k stars 265 forks source link

Code restructuring #45

Closed vinaysb closed 3 years ago

vinaysb commented 4 years ago

Hello, I was wondering if you would be ok with me changing the setup files to current standards, so that the main config entries, such as requirements, script name, entry point, are in the setup.cfg.

Also using click library instead for CLI

schmittner commented 4 years ago

HI @vinaysb, creating setup.cfg is a good idea.

However, I do not see a reason to use a non-standard CLI library. I would like to keep dependencies as low as possible.

vinaysb commented 4 years ago

Ok great, I made the changes in my fork. I had to change the tree structure, by having an intermediary src folder, otherwise relative imports would break.

vinaysb commented 4 years ago

Also, click is used for making the code look much neater with the help of decorators, groups & commands. You will also have help argument created for you by default

https://docs.python-guide.org/scenarios/cli/