search

seemoo-lab / opendrop

An open Apple AirDrop implementation written in Python
https://owlink.org
GNU General Public License v3.0
8.5k stars 266 forks source link

Create "opendrop" package for pip installation #8

Closed bf closed 4 years ago

bf commented 4 years ago

Currently the command pip3 install opendrop shows that the package is not registered in the PIP repositories yet, therefore it is easy for someone malicious to claim the package and serve arbitrary code with it.

I suggest the maintainers of this project register it with PIP so it can be installed with above-mentioned command.

SEJeff commented 4 years ago

This would require sending the changes to python-zeroconf back upstream first.

jsjohnst commented 4 years ago

@SEJeff I would still recommend putting a placeholder package up for the reasons indicated by @bf. If you don't, someone else will.

SEJeff commented 4 years ago

@jsjohnst agreed, but a placeholder, not the full version.

schmittner commented 4 years ago

Thanks @bf, that's a valid concern.

I've created a placeholder project at pypi.org. I'll publish releases there if the projects becomes more mature.

jstasiak commented 4 years ago

This would require sending the changes to python-zeroconf back upstream first.

I don't think it's required strictly speaking, but I'd be interested in having the changes upstream regardless. :)

Note that there's been some work on IPv6 (notably https://github.com/jstasiak/python-zeroconf/pull/174) so there may be some clash here as the readme says

We use a modified version of the python-zeroconf package (essentially adding rudimentary IPv6 and AWDL support)

I'm sure we'll work something out though.

PS. Nice project!

schmittner commented 4 years ago

The package is available at https://pypi.org/project/opendrop/