seemoo-lab / owl

An open Apple Wireless Direct Link (AWDL) implementation written in C
https://owlink.org
GNU General Public License v3.0
1.22k stars 85 forks source link

make error #84

Closed keys-i closed 12 months ago

keys-i commented 12 months ago

i tried to install owl but the following error shows up

python) radhesh@dator:~/github/owl/build$ sudo make install
[  5%] Built target radiotap
[ 51%] Built target awdl
[ 64%] Built target owl
[ 67%] Building CXX object googletest/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
In file included from /home/radhesh-go/github/owl/googletest/googletest/src/gtest-all.cc:42:
/home/radhesh-go/github/owl/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
/home/radhesh-go/github/owl/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/home/radhesh-go/github/owl/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
/home/radhesh-go/github/owl/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [googletest/googletest/CMakeFiles/gtest.dir/build.make:76: googletest/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:322: googletest/googletest/CMakeFiles/gtest.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

i believe there should not be a error

BenjaminMickler commented 12 months ago

This is an issue with googletest so that's where the bug should have been reported.

According to https://github.com/google/googletest/issues/3835, the issue has been fixed, but the Git submodule in this repo still points to googletest release 1.10.0. To solve the problem, update the googletest submodule to the latest version (git submodule update --remote --merge). Then try building owl again.

moritztim commented 6 months ago

@radhesh1 This is not completed. You should keep it open, since it's not been fixed, it still needs manual intervention