seen-haus / seen-contracts

Seen Haus contract suite
GNU General Public License v3.0
8 stars 2 forks source link

MCL-01C: Inexplicable Deviancy #26

Closed JayWelsh closed 2 years ago

JayWelsh commented 2 years ago

MCL-01C: Inexplicable Deviancy

Type Severity Location
Code Style Informational MarketClientLib.sol:L32

Description:

All contracts in the system are conforming to the EIP-1967 storage slot specification apart from this instance.

Example:

/**
 * @dev Storage slot with the address of the Seen.Haus AccessController
 * This is obviously not a standard EIP-1967 slot.
 */
bytes32 internal constant PROXY_SLOT = keccak256('Seen.Haus.MarketClientProxy');

Recommendation:

We advise this instance to also conform to the standard as there is no justification as to why it should deviate.

JayWelsh commented 2 years ago

Awaiting response from author of original deviancy to confirm whether or not there was a reason for it

JayWelsh commented 2 years ago

Appeal:

Screenshot 2022-01-04 at 16 38 47