search

seen-haus / seen-contracts

Seen Haus contract suite
GNU General Public License v3.0
8 stars 2 forks source link

MCP-01C: Redundant `payable` Constructor #27

Closed JayWelsh closed 2 years ago

JayWelsh commented 2 years ago

MCP-01C: Redundant payable Constructor

Type Severity Location
Language Specific Informational MarketClientProxy.sol:L47

Description:

The constructor of the contract is marked as payable.

Example:

constructor(
    address _accessController,
    address _marketController,
    address _impl
) payable {

Recommendation:

If this is indeed desired, we advise documentation to be added to support it. Otherwise, we advise it to be omitted from the codebase as it can lead to loss of funds.

JayWelsh commented 2 years ago

Resolved via https://github.com/seen-haus/seen-contracts/pull/37