search

seen-haus / seen-contracts

Seen Haus contract suite
GNU General Public License v3.0
8 stars 2 forks source link

MHB-01S: Redundant Comparison of `bool` Variable #7

Closed JayWelsh closed 2 years ago

JayWelsh commented 2 years ago

MHB-01S: Redundant Comparison of bool Variable

Type Severity Location
Code Style Informational MarketHandlerBase.sol:L135, L137, L205

Description:

The linked statements perform a direct comparison between a bool literal and a bool variable.

Example:

if (supported == true) {

Recommendation:

We advise the bool variable to be used directly instead in either its negated (!) form or its normal one depending on the need.

JayWelsh commented 2 years ago

Resolved by https://github.com/seen-haus/seen-contracts/pull/47 and https://github.com/seen-haus/seen-contracts/pull/48