Closed fwkoch closed 6 years ago
Merging #255 into dev will decrease coverage by
0.03%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## dev #255 +/- ##
==========================================
- Coverage 96.24% 96.21% -0.04%
==========================================
Files 16 16
Lines 2319 2322 +3
==========================================
+ Hits 2232 2234 +2
- Misses 87 88 +1
Impacted Files | Coverage Δ | |
---|---|---|
properties/base/instance.py | 95.6% <66.66%> (-0.99%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0fec8ee...9d23620. Read the comment docs.
I'm rejecting - this conflates initialization and deserialization. On init, we shouldn't see __class__
, if we have a dictionary with that present, we should be deserializing
instead (since that key would be created with serialize
).
This is only valid if
__class__
is identical to theinstance_class
name. If more complicated behavior is required, deserialize should be used.As an example, say you have:
previously this would be fine:
but this would fail:
instead requiring:
With this PR, all of the above are valid.