search

seequent / properties

An organizational aid and wrapper for validation and tab completion of class properties/traits.
http://propertiespy.rtfd.org
MIT License
18 stars 9 forks source link

Remove value error catch on bool casting #280

Closed fwkoch closed 5 years ago

fwkoch commented 5 years ago

See #264

codecov[bot] commented 5 years ago

Codecov Report

Merging #280 into dev will increase coverage by 0.12%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #280      +/-   ##
==========================================
+ Coverage   96.42%   96.54%   +0.12%     
==========================================
  Files          17       17              
  Lines        2375     2372       -3     
==========================================
  Hits         2290     2290              
+ Misses         85       82       -3
Impacted Files Coverage Δ
properties/basic.py 97.5% <0%> (+0.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1786b90...0041a61. Read the comment docs.

bsmithyman commented 5 years ago

(cherry picking docs fix above for 3.5/3.6 test fails)

fwkoch commented 5 years ago

@bsmithyman - re. your commentary on how this is possible - the biggest thing is that ValueError vs any other error type is totally arbitrary. Like, the example code you had in your commentary could have raised any error type, so why do we only catch ValueError? So with that reasoning, it becomes either catch everything or catch nothing, and in that case, the latter makes way more sense.

bsmithyman commented 5 years ago

Ha, yes, completely agree @fwkoch.