seequent / properties

An organizational aid and wrapper for validation and tab completion of class properties/traits.
http://propertiespy.rtfd.org
MIT License
18 stars 9 forks source link

update from json to allow values that have already been cast to bools #289

Closed lheagy closed 5 years ago

lheagy commented 5 years ago

If using deepdish to serialize to and deserialize from an HDF5 file, booleans come back as a np.bool_, but the deserializer currently doesn't accommodate that:

image

This allows and BOOLEAN_TYPES to be passed through the from_json

codecov[bot] commented 5 years ago

Codecov Report

Merging #289 into master will decrease coverage by 0.03%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   96.63%   96.59%   -0.04%     
==========================================
  Files          17       17              
  Lines        2376     2378       +2     
==========================================
+ Hits         2296     2297       +1     
- Misses         80       81       +1
Impacted Files Coverage Δ
properties/basic.py 97.8% <50%> (-0.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6daa40a...27aabcf. Read the comment docs.