search

seer-lab / github-code-walker

A code walkthrough and exploration tool for GitHub projects.
0 stars 0 forks source link

#3: Fix cut off text on navbar, and ensure it scrolls vertically #6

Open randyfortier opened 8 years ago

randyfortier commented 8 years ago

As it is, the navbar will not scroll vertically. There is a ScrollView component you could wrap all the TextViews in that will solve this problem. It won't solve the horizontal text problem, though.

  1. One way to solve this is to make the navbar use the slide out panel you had before. Basically, wrap all of the TextViews in a . This solves the problem, since it pulls out to the necessary size, and adds a feature of being able to hide the navbar when not needed.
  2. Using ListView with a custom UI (or even a standard TextView) would solve both issues at once. The navbar cannot be hidden, but the ListView should show all of the TextView or custom UIs, as long as you didn't set a fixed width for the navbar component.

These two approaches could even be combined by putting a ListView into a DrawerLayout.

Adam-Anthony commented 8 years ago

Navbar scrolling working through ScrollView and HorizontalScrollView.

Did not make it a slide out panel, I think it's nice to have the option of seeing the folder as a constant on the side, and navbar seemed to be either hidden or the main focus.