search

seerai / godal

Go bindings for GDAL
Other
0 stars 0 forks source link

Add Grid functions #34

Open mschulist opened 3 months ago

mschulist commented 3 months ago

In order to implement inverse distance weighting (assuming we will use GDAL), we will need to add gridding functions. The original version of godal (where this fork came from) now has gridding functions, but they have updated many other parts of godal so it's not quite as simple as pasting in their version.

We could (maybe?) just use their version of godal, assuming it has all of the same functionality our version has.

dwilson1988 commented 3 months ago

Are you referring to the airbusgeo one? We formed from the same repo they forked from, but our godal is not a fork of that.

What advantages does GDAL buy us here over just implementing it directly with a KDTree?

mschulist commented 3 months ago

This one (https://github.com/lukeroth/gdal) is the one we forked, I think.

GDAL has (essentially) a one-liner that would take in the features (once converted to their format) and output a raster, similar to rasterize (I think?).

That doesn't mean it's better than directly implementing though

https://gdal.org/programs/gdal_grid.html#examples

dwilson1988 commented 3 months ago

Worth a shot! If we run into woes, can always implement ourselves. Good find

dwilson1988 commented 3 months ago

Didn't realize that was still maintained. Oh well. Ours suits our purposes, but we may want to convert to the airbus version at some point

mschulist commented 3 months ago

It is maintained as long as we don't count the bug that someone made a PR for a few months ago...

I was able to (mostly) copy-paste from the original repo into ours and get the grid to work. It seems like the difficult part will be translating between GDAL and our chunks/features

dwilson1988 commented 3 months ago

We have utilities for that in boson-core/utils/gdal

On Fri, Aug 9, 2024, 5:19 PM Mark Schulist @.***> wrote:

It is maintained as long as we don't count the bug that someone made a PR for a few months ago https://github.com/lukeroth/gdal/pull/102...

I was able to (mostly) copy-paste from the original repo into ours and get the grid to work. It seems like the difficult part will be translating between GDAL and our chunks/features

— Reply to this email directly, view it on GitHub https://github.com/seerai/godal/issues/34#issuecomment-2278869719, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACM2H3EPT6RQ3WHVPMJIWYLZQVFAPAVCNFSM6AAAAABMI7FB32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYHA3DSNZRHE . You are receiving this because you commented.Message ID: @.***>