seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://seerge.github.io/g-helper/
GNU General Public License v3.0
7.41k stars 265 forks source link

Battery Charge Limiter does not work as expected #1013

Closed scrazzz closed 1 year ago

scrazzz commented 1 year ago

Describe the bug As the title says, Battery Charge Limiter does not work as expected. It only works when it is set to 80%. If I change the value to 85% or even 90% it keeps charging until it's at 100%.

I did read the README and understand what may cause this issue. But I have stopped all Asus services and have uninstalled MyAsus application from my machine. I have uninstalled Armory Crate and furthermore did some more cleanup using BloatyNosy.

Clear scenario to Reproduce

  1. Plug in charger
  2. Open g-helper
  3. Set Battery Charge Limiter to 90%
  4. Wait for it to charge and you'll notice that it keeps charging beyond 90%

Expected behavior To not charge the battery beyond 90%.

App Logs n/a

Screenshots or screencasts n/a

Desktop (please complete the following information):

Asus software

Additional context n/a

seerge commented 1 year ago

@scrazzz hello,

It's possible that some devices just don't support 85% or 90% on hardware level :) Since you have ignored requested logs, i can't really say more.

Since 80% is working - there is nothing to "fix" here

scrazzz commented 1 year ago

It's possible that some devices just don't support 85% or 90% on hardware level

Hmm I see, thanks for the info.

Since 80% is working - there is nothing to "fix" here

Well, then why have a slider to adjust it on hardwares that don't support it? I'd much rather prefer a checkbox to avoid the confusion :)

seerge commented 1 year ago

@scrazzz because there is no way to know in advance if does support or not :) wast majority of devices do support any values here

scrazzz commented 1 year ago

I'll try to get the logs later and open a new issue which links here.