seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://seerge.github.io/g-helper/
GNU General Public License v3.0
7k stars 255 forks source link

[Bug Report] misrepresentation of max cpu fan speed and charge limit not applied when not inside windows #1771

Closed mjishnu closed 9 months ago

mjishnu commented 9 months ago

Describe the bug

  1. misrepresentation of max cpu fan speed: After calibration the max cpu fan speed is 6300 but it shows max as 6400 in the graph

  2. charge limit not applied when not in windows: In the past when i used to set charge limit using myasus it stayed the same even when not in windows (reboot/starting/poweroff) but in case of ghelper it works fine while i am inside windows but when its reboot/starting/turned off but plugged to a charger its not applied (myasus is installed and charge limit is set to 60 same in case of ghelper but asus services are stoped (extra --> stop)), i am not sure but myasus used to set it in bios level or something i think.

App Logs log.txt

Screenshots or screencasts 1.

Screenshot 2023-12-22 111229

2.

Screenshot 2023-12-22 111330

Desktop (please complete the following information):

Asus software

Kikimahe commented 9 months ago

Hi,

1- Your Fan must have exceeded 6300 RPM (6301, 6315, 6350 ....) The graph logically displays at 6400 RPM max. :)

If you are really sure that your fan can't exceed 6300 RPM MAX, Then you can correct it manually :

(63= 6300 RPM for CPU and 64 = 6400 RPM for GPU)

But I think that the calibration will correct again if you exceed 6300 RPM.

2- Charge limit is applied AFTER starting Ghelper (or my Asus), It's impossible before. It is normal for the battery to charge for a few seconds upon Windows startup or restart. After several starts/restarts you necessarily exceed the 60% charge limit ;-)

@seerge This should be added to the readme FAQ. This is a redundant question. ;-) https://github.com/seerge/g-helper?tab=readme-ov-file#battery-charge-limiter-is-not-working

seerge commented 9 months ago

@m-jishnu hello,

  1. Chart rounds it to each 200RPM, so you have 6400. Also don't look at that precisely anyway, as it's still up to BIOS on how to interpret fan curve and run fans and deviate from that too if it's programmed like that

  2. Many models reset charge limiter on reboot, it's normal. As soon as app starts - it will set it again :) It can't start w/o windows running obviously. Charge limit is set on BIOS level, but BIOS resets settings on reboot.

Closing as there is nothing to fix here :)

mjishnu commented 9 months ago

thanks for the replies @Kikimahe, @seerge also i have a question @seerge will it possible to change the undervolte value to floats as i can see its currently integers more over what does each value means if i set as -16 is it equal to -0.016V?

seerge commented 9 months ago

@m-jishnu most probably it's mV :) but anyway, this is just a value that app sends to AMD SMU

mjishnu commented 9 months ago

@m-jishnu most probably it's mV :) but anyway, this is just a value that app sends to AMD SMU

so will it be possible to make them float like if my system is stable in -17 in 99% time but sometime freezes i want to try values like -16.5, -16.8 etc does the amd smu accept such value ?

seerge commented 9 months ago

@m-jishnu no, that's not possible

mjishnu commented 9 months ago

@seerge are you interested in implementing these features

  1. game/app detection, if I want particular apps/games to use certain profile with certain options(like turbo with display overdrive on fps games) when they launch automatically and switch back to my normal profile once I close/ changes the app. similar to the one found in AC

  2. Implementing UI interface for dark theme and other advanced feature also it would be great if there was a button which opens confg.json too.

Also hats off to your dedication to the project!, never seen any maintainer be so much involved with the community.

seerge commented 9 months ago

@m-jishnu

  1. Game detection is very difficult, so - no

  2. App already supports dark UI, and follows windows app settings. You can override that in a config https://github.com/seerge/g-helper?tab=readme-ov-file#override-ui-theme

mjishnu commented 9 months ago

@m-jishnu

  1. Game detection is very difficult, so - no
  2. App already supports dark UI, and follows windows app settings. You can override that in a config https://github.com/seerge/g-helper?tab=readme-ov-file#override-ui-theme

oh i see so no game detection, in 2 what i mean was ui for changing those setting anyways thanks!