seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://g-helper.com
GNU General Public License v3.0
7.59k stars 266 forks source link

Slow / Sustained sPPT / SPL CPU power sliders are reversed or labelled incorrectly #1885

Closed elite-NSX closed 9 months ago

elite-NSX commented 9 months ago

v141 and v144 the fast / slow power sliders are reversed / labelled incorrectly

adj. fast slider then used ryzenadj command prompt and slow CPU wattage moves and vice versa

plz fix soon cheers and thank you for the awesome tool

seerge commented 9 months ago

@elite-NSX i don't think that's the case.

Post a log from the app as it was clearly asked in issue template. Also please attach screenshots from HWinfo showing limits.

elite-NSX commented 9 months ago

image

srry its the slow limit and sustained limits that mayb incorrect, how /where do i get the log if image isnt enough

elite-NSX commented 9 months ago

log.txt

elite-NSX commented 9 months ago

srry again for not following issue template

seerge commented 9 months ago

Looks like they can be indeed swapped for AMD

@IceStormNG can you please check on your Intel device, if PL1 and PL2 sliders actually are also swapped ?

You can just set different values and run cinebench23 and monitor in hwinfo if it uses higher value first, and then goes to lower

seerge commented 9 months ago

@elite-NSX this build should have SPL / SPPT swapped

GHelper.zip

elite-NSX commented 9 months ago

confirmed issue in my old build then used same method for new build issue was fixed the slider adj. correct values now cheers thx man

is that new build based off v145 pre release or 144 latest ''stable''

seerge commented 9 months ago

@elite-NSX 145 is same as 144. This change is not published yet, as I want to verify if PL1/PL2 values for Intel are also swapped or not (they are set by same "endpoints" in asus driver)

elite-NSX commented 9 months ago

ok but i can jus use the build u provided in the mean time and i edited the title of issue so no confusion

elite-NSX commented 9 months ago

if their set in asus driver and not in AMD driver then this might be a one off case im not on latest drivers and dont plan on updating mayb ask some1 with flow x13 GV302XU whos on latest drivers and windows updates to confirm swapped values

cheers man and thank again

seerge commented 9 months ago

@elite-NSX it's set in BIOS via Asus driver (that servers just as a proxy-layer)

This is same method as Armoury sets values, so i'm 99% sure it doesn't change from version to version as otherwise it would break Armoury as well :)

seerge commented 9 months ago

@IceStormNG i checked Asus Control Interface DSDT dump for M16 2023 and how it's set there, and it looks like it's also swapped for Intel

        Method (SPLX, 2, Serialized)
        {
            If ((FANM == 0x04))
            {
                SECC (0x46, One)
                Switch (Arg0)
                {
                    Case (0x001200A0) <---- this endpoint was called PL1 before
                    {
                        M6F1 = Arg1
                    }
                    Case (0x001200A3) <---- this endpoint was called PL2 before
                    {
                        M6F0 = Arg1
                    }
                    Case (0x001200B0)
                    {
                        M6EC = Arg1
                    }
                    Case (0x001200B1)
                    {
                        M6F1 = Arg1
                    }
                    Default
                    {
                        SECC (0x46, Zero)
                    }

                }
            }
        }

While in reality

0x001200A3 assigns something called M6F0 0x001200A0 assigns something called M6F1

Judging from names of those variables, looks like F0 is sustained limit (i.e. PL1) and F1 is boost limit (i.e. PL2)

elite-NSX commented 9 months ago

ok i am on the latest bios version v311 if that helps

elite-NSX commented 9 months ago

im glad i could help

seerge commented 9 months ago

@Kikimahe i think you also have Intel, can you test if Pl1 and PL2 are swapped ? set something like PL1 30 and PL 2 60 and run cinebench, to see on what power consumption it starts to run? :)

IceStormNG commented 9 months ago

@IceStormNG i checked Asus Control Interface DSDT dump for M16 2023 and how it's set there, and it looks like it's also swapped for Intel

I just tested with 0.144 and yes, PL1 and PL2 are swapped. PL1 slider sets the burst limit and PL2 slider the sustained limit for me.

seerge commented 9 months ago

@IceStormNG great, thanks for confirmation! 🙇

I have swapped them and pushed live already as 0.146.

Can you check if 146 works correctly ?

IceStormNG commented 9 months ago

@seerge with the current repo state, it works fine judged by a quick test.

Edit: Maybe there should be an update that you cannot set PL2 lower than PL1 because it makes not sense. So that it moves the other slider if you exceed its value, like what AC and some other tools do.

seerge commented 9 months ago

@IceStormNG great, closing as completed then

Kikimahe commented 9 months ago

@Kikimahe i think you also have Intel, can you test if Pl1 and PL2 are swapped ? set something like PL1 30 and PL 2 60 and run cinebench, to see on what power consumption it starts to run? :)

Hi Seerge, I apologize for not helping you today. I was very busy with work. ;'(

V0.146 - Test Cinebench. PL1 : 30W PL2 60W

Hwinfo : Consumption starts with 60W then decreases to 30W

seerge commented 9 months ago

@Kikimahe great, thanks for confirming that 0.146 works as intended.