seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://seerge.github.io/g-helper/
GNU General Public License v3.0
7.25k stars 263 forks source link

Zephyrus G16 2024 Incorrect Slash Lighting Preset on Lid Close #2815

Closed sgDanPowell closed 2 months ago

sgDanPowell commented 3 months ago

Rules

What's wrong?

Disabling Slash lighting when Lid is closed works correctly; however, if you keep the Slash lighting enabled when the lid is closed it appears to use the settings you previously had in Armory Crate rather than the setting you have in G Helper.

How to reproduce the bug?

Keep Slash Lighting Enabled in G Helper. Close the Laptop Lid. Observe that the Lighting preset may be different to the one you have selected in G Helper due to it defaulting to the setting selected for closed lid in Armory crate.

Logs

log.txt

Device and Model

GU605MZ-QR045W

Additional information.

No response

Armoury Crate

Uninstalled

Asus Services

0

Version

0.178.0

OS

Windows 11 Home 22H2

seerge commented 3 months ago

@sgDanPowell hello, it's not AC animation. It's most likely sleep animation that you see when lid is closed :)

It's controlled by firmware, so you can't change that - only turn it off completely.

sgDanPowell commented 3 months ago

The sleep animation can be controlled in Armory Crate IIRC?

sgDanPowell commented 3 months ago
image

If I have "Stay activate animation pattern when lid is closed" then it seems to also play the Flux pattern I have selected when lid closed/sleep

This setting carries over even if you uninstall Armory Crate and use only G Helper - if I change to "Static" or another setting in G Helper, it keeps the above setting from armory crate

seerge commented 3 months ago

@sgDanPowell

sgDanPowell commented 3 months ago

Armory Crate settings examples:

Theme is Glitch. Animation Pattern is Bounce. Show Sleep Animation Pattern is TRUE. Stay Activate Animation Pattern when Lid is Closed is set to TRUE.

image

Theme is Glitch. Animation Pattern is Bounce. Show Sleep Animation Pattern is TRUE. Stay Activate Animation Pattern when Lid is Closed is set to FALSE.

image

Theme is Neoretro. Animation Pattern is Flux. Show Sleep Animation Pattern is TRUE. Stay Activate Animation Pattern when Lid is Closed is set to TRUE.

image

Theme is Neoretro. Animation Pattern is Flux. Show Sleep Animation Pattern is TRUE. Stay Activate Animation Pattern when Lid is Closed is set to FALSE.

image
seerge commented 3 months ago

@sgDanPowell great, thanks for the info. But what is the actual behavior of the SlashLighting when lid is closed in those situations ? Does setting "Stay Activate Animation Pattern" to FALSE - keep same animation as when lid is open ?

sgDanPowell commented 3 months ago

Just uploading some comparison videos with the above settings now :)

sgDanPowell commented 3 months ago

But yes, it appears that when Stay Activate Animation Pattern is flagged as True, it keeps the same pattern. When it is flagged as false, it appears to revert to a generic pulsing pattern as videos show

https://www.transfernow.net/dl/20240708WIQ2n5aT

seerge commented 3 months ago

@sgDanPowell ok, blinking pattern is very similar to a default "sleep" animation on any asus keyboard (they also blink).

I know a payload for Stay Activate Animation Pattern checkbox. And I can simply turn it OFF all the time . Then it will keep default pattern when lid is closed.

I'm just not 100% sure if it's desired behavior for everyone and I also don't want to overcomplicate UI (even more) with an extra checkbox ....

What do you think ?

seerge commented 3 months ago

@sgDanPowell try this build, it should keep default pattern ON all the time

GHelper.zip

sgDanPowell commented 3 months ago

It does for the most part keep the Selected pattern on Lid closed, but it seems to revert back to the default static blinking pattern occasionally

sgDanPowell commented 3 months ago

https://github.com/seerge/g-helper/assets/157390280/e7c99796-d3e6-4adc-95dc-a907fe838acc

https://github.com/seerge/g-helper/assets/157390280/2d10ecfa-0804-4742-b6c0-7cd1eb651cde

Minemetero commented 3 months ago

How do you keep your laptop clean? I left my finger oil on the slash lighting.

seerge commented 2 months ago

@sgDanPowell ok great.

It's AC service that reverts it back probably :) You will need to disable it in windows services or (eventually) uninstall AC using uninstaller

sgDanPowell commented 2 months ago

Appears to still revert after a short period of time once the machine is Sleeping with the Lid closed

Armory Crate was uninstalled using the official Armory crate uninstaller tool; unsure what service may be hijacking it back?

https://github.com/seerge/g-helper/assets/157390280/ad98d1b5-50a9-4c6d-bfa4-037cdb7bcdee

seerge commented 2 months ago

@sgDanPowell it could be another animation this time - "sleeping" (when laptop goes to sleep and it starts blinking)

I'm not sure if it's a good idea of disabling this one tho, as when you see it - you know that proper hardware sleep is ON now. So as for this part I would keep it as is now.

--

To summarize there are 2 "automated" animations for Slash Lighting

seerge commented 2 months ago

@sgDanPowell changes pushed to the last 0.180 release.

I strongly suggest to keep sleep animation as is (cause then you can separate if device is sleeping or just has lid closed). And this is also same as Anime Matrix behaves in older devices. So it's consistent :)

Closing as resolved then.