seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://seerge.github.io/g-helper/
GNU General Public License v3.0
6.96k stars 254 forks source link

Can't change keyboard lightning #2973

Closed Rooie100 closed 3 weeks ago

Rooie100 commented 1 month ago

Rules

What's wrong?

As the title says, i cant change the lightning in G-helper. Only when i click ''run Asus services'' then it works. Dynamic lightning is disabled via windows.

I'm also using the latest version of G-helper.

How to reproduce the bug?

Go to G-helper Click on a different color Keyboard stays in breathing

Logs

log.txt

Device and Model

ASUS Vivobook S 15 OLED M5506NA.

Additional information.

No response

Armoury Crate

Uninstalled

Asus Services

None

Version

0.184.0

OS

Windows 11 H

seerge commented 1 month ago

@Rooie100 hello,

Is it only backlight modes that don't work or also backlight brightness ?

Cause I see that brightness controls seem to exist on your device and work

8/13/2024 5:31:08 PM: TUF Brightness = 128 : OK
8/13/2024 5:31:09 PM: WMI event 199
8/13/2024 5:31:09 PM: TUF Brightness = 129 : OK
8/13/2024 5:31:09 PM: WMI event 199
8/13/2024 5:31:09 PM: TUF Brightness = 130 : OK
8/13/2024 5:31:09 PM: WMI event 199
8/13/2024 5:31:09 PM: TUF Brightness = 131 : OK

While backlight modes are absent

8/13/2024 5:30:27 PM: AuraMode: AuraStatic
8/13/2024 5:30:27 PM: TUF RGB = B4-00-FF-80-40-EB : 0 <-- 0 means it's not there
8/13/2024 5:30:27 PM: TUF RGB = B4-00-FF-80-40-EB : 0

What happens if you start asus services, does the backlight mode selection in G-Helper itself start suddenly working ? Or how do you change backlight otherwise ?

Rooie100 commented 1 month ago

Hi, thanks for the response.All the backlight modes don’t work, even within windows. I also can’t change the brightness or color. When i start the asus services, the lightning control within g-helper all of a sudden starts working. If you need anymore info let me know!On 13 Aug 2024, at 17:43, Serge @.***> wrote: @Rooie100 hello, Is it only backlight modes that don't work or also backlight brightness ? Cause I see that brightness controls seem to exist on your device and work 8/13/2024 5:31:08 PM: TUF Brightness = 128 : OK 8/13/2024 5:31:09 PM: WMI event 199 8/13/2024 5:31:09 PM: TUF Brightness = 129 : OK 8/13/2024 5:31:09 PM: WMI event 199 8/13/2024 5:31:09 PM: TUF Brightness = 130 : OK 8/13/2024 5:31:09 PM: WMI event 199 8/13/2024 5:31:09 PM: TUF Brightness = 131 : OK

While backlight modes are absent 8/13/2024 5:30:27 PM: AuraMode: AuraStatic 8/13/2024 5:30:27 PM: TUF RGB = B4-00-FF-80-40-EB : 0 <-- 0 means it's not there 8/13/2024 5:30:27 PM: TUF RGB = B4-00-FF-80-40-EB : 0

What happens if you start asus services, does the backlight mode selection in G-Helper itself start suddenly working ? Or how do you change backlight otherwise ?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

seerge commented 1 month ago

@Rooie100 then it looks like your device is quite unique and asus services work as a proxy between actual backlight and apps that want to set it, since when they are running all backlight commands work in g-helper.

It may be very difficult to find a way to directly set backlight in your case without having access to the actual device.

Can you make a DSDT dump as explained in Method 2 and upload it here ?

seerge commented 1 month ago

@Rooie100 any updates with the dump here ?

GDisco0730 commented 1 month ago

I have this same issue with Asus ProArt P16. When Ghelper is running amd Asus service are stopped, I am unable to change backlight color, modes, or brightness just nothing happens at all when any changes made. Even when I restart services, I am now able to change backlight brightness and modes, but still not the colors.

seerge commented 1 month ago

@GDisco0730 does your device even support different colors? Cause Proart X13 does not for example.

As for the rest, same question please upload DSDT dump from Method 2 here (and log from the app as well)

Rooie100 commented 1 month ago

Hey Seerge,

Sorry to keep you waiting, i attached the dsdt in ZIP form/ dsdt.zip

seerge commented 1 month ago

@Rooie100 hello, thanks.

Can you check if this build makes any difference ? GHelper.zip

gbassani commented 1 month ago

I have the same issues with the vivobook s 16. Testing the new zip you added.

So far, the colors are now indexing again like it was new, constantly cycling through the colors (was just static blue prior).

I have my Asus uninstalled as well as having run the armoury crate removal tool.

Edit: Just to clarify, even with changing the color mode and/or color, the observed behavior remains with color cycle.

seerge commented 1 month ago

@gbassani i don't think that you are similar to other people here :) as they can't control backlight (due to some unknown method specific only to that devices?)

If you had static blue - that's a sign of windows Dynamic Lighting being ON and taking over. Just make sure to disable it and regular mainstream build should work fine.

gbassani commented 1 month ago

Thank you for the info, missed that in the FAQ's. Even with dynamic lighting off (both globally and under the keyboard), the colors continue to cycle. I also tried setting both the personalization color and within G-Helper to static red. This is under the mainstream build.

Model is the M5606WA with the AMD stack. Also checked and it isn't in the list of compatible devices, I can submit for it there.

seerge commented 1 month ago

@gbassani

Rooie100 commented 1 month ago

@Rooie100 hello, thanks.

Can you check if this build makes any difference ? GHelper.zip

Hey,

It semi fixed it! I can control the brightness now, but not the color. It stays in breathing mode....

seerge commented 1 month ago

@Rooie100 ok, good news, can you try this build and post a log from it ?

GHelper.zip

seerge commented 1 month ago

P.S. @gbassani @GDisco0730 you both can try build above as well

Rooie100 commented 1 month ago

Hi,

Here is the log! Thanks for the effort already, i'm happy that i can change the brightness at least.

log.txt

seerge commented 1 month ago

@Rooie100 ok, but do backlight modes work in this build or not ?

seerge commented 1 month ago

Cause if it does not, it looks like not only endpoint (i.e. where to set backlight setting) but also structure of the command itself is different.

Try this build instead, to see if it makes any difference (and again post a log) GHelper.zip

seerge commented 1 month ago

If even that build does not work, it means we need to monitor actual commands Asus Services send to hardware in order to change backlight modes

I have a guide on how to do that https://github.com/seerge/g-helper/wiki/_ACPI-Monitoring-and-Debugging

Rooie100 commented 4 weeks ago

Hi,

Last build does not change a thing, can't change the lightning withing G-helper. Log is attached, thanks for the response again! log.txt

seerge commented 4 weeks ago

@Rooie100 ok, thanks for checking.

Then the only way would be to intercept actual payloads that Asus service sends to the device in order to set backlight modes as explained in https://github.com/seerge/g-helper/wiki/_ACPI-Monitoring-and-Debugging

You will need to follow the guide, and then change backlight using Asus software (not G-Helper!) and record payloads

Ideally would be good to :

kennycoder commented 4 weeks ago

Try deleting %AppData%/GHelper folder. Fixed it for me. Unfortunately I didn't it backup up so I couldn't do the diff. Anyone still experiencing issues, please do it and see what's the difference... will be helpful. Mine is G14 from 2023.

seerge commented 4 weeks ago

@kennycoder G14 2023 backlight control is 100% supported (and used by dozens of thousands of people). Config removal won't do anything except erasing of own G-Helper settings.

People in this thread have new (mid 2024 devices) that use different backlight controls.

gbassani commented 3 weeks ago

P.S. @gbassani @GDisco0730 you both can try build above as well

Apologies for delay, tried the latest zip package above from 3 days ago and still stuck on static white. Dynamic is disabled globally and at keyboard level. Also attempted to set to static red in personalization and in g-helper.

Attached the log.txt, screenshots of the dynamic lighting/g-helper, and the dsdt log.txt

dsdt.zip

screenshots.zip

Edit: clarified about package used Edit2: Previously I changed it through the dynamic lighting having it match the accent colors of the current window. I ran the uninstaller as that was in the readme and as this is my first Asus laptop, was not sure what AC components may or may not have been pre-installed. I had also removed the my Asus app.

seerge commented 3 weeks ago

@gbassani hello, thanks for checking. As I have explained in a comment above i need someone to record actual payloads asus service sends to the device. As new Vivobooks seem to use different protocol completely :)

seerge commented 3 weeks ago

@Rooie100 any updates here ? :)

gbassani commented 3 weeks ago

@gbassani hello, thanks for checking. As I have explained in a comment above i need someone to record actual payloads asus service sends to the device. As new Vivobooks seem to use different protocol completely :)

Working on this--spinning up a sandboxed installation. I'll use that tool after clean install prior to installing MyAsus to use the windows dynamic lighting and then will try after installing MyAsus for a second file. Command Interface v3 will be installed for both prior.

Edit: do you want me to also try capturing for this AsusKeyboard driver? image

The attached is all I was able to generate over several minutes when clicking through the colors as well as the lighting types. test.log

seerge commented 3 weeks ago

@gbassani hello, thanks.

Your log contains only 2 commands, just for toggling backlight brightness, but both of them are already in G-Helper since the very beginning (and as I understand it works for you anyway)

0x0050021 -> 0x03 ON
0x0050021 -> 0x83 OFF

What I need is a payloads for changing backlight modes using Asus software :)

Wyrddann commented 3 weeks ago

@seerge Hi! I also have this same issue with my TUF A15 2023.

seerge commented 3 weeks ago

@Wyrddann then you need to do the same thing I'm asking from other people here

Then the only way would be to intercept actual payloads that Asus service sends to the device in order to set backlight modes as explained in https://github.com/seerge/g-helper/wiki/_ACPI-Monitoring-and-Debugging You will need to follow the guide, and then change backlight using Asus software (not G-Helper!) and record payloads Ideally would be good to :

  • set different modes (but keep same color) and capture that.
  • then keep same mode but change colors and capture that as well :)
seerge commented 3 weeks ago

@Rooie100 @gbassani @Wyrddann

Also please check if this build accidentally makes any difference (as someone in other thread has helped me with discovering)

GHelper.zip

gbassani commented 3 weeks ago

@seerge From what I can tell, there is not a way to change the keyboard colors from within the MyAsus app, I have only been able to through personalization/dynamic lighting for the vivobook.

I can try installing the ROG lighting control app and see if that lets me, otherwise I might be stuck. Tried the new build and no luck there, if I turn the dynamic lighting off I get static white regardless of settings in ghelper.

As for the log I uploaded, that was all that was captured when toggling in dynamic lighting for colors, brightness, lighting behavior (static to breathing) and the rate of the effect (faster/slower breathing). The behavior is different with these builds, I can't even get the breathing to work on static blue like I had originally.

Going to stick without g-helper for now, let me know if there are any other logs you'd like me to attempt if anyone else is requesting the new vivobook.

seerge commented 3 weeks ago

@gbassani so you can't change backlight using Asus apps ? Then G-Helper won't be able to do that neither as it relies on Asus endpoints / protocols. You have Vivobook so ROG apps won't work on your device.

If the only "official" way to control backlight on your device is by using Dynamic Lighting - then you should just use that.

seerge commented 3 weeks ago

@gbassani P.S. What you can try to do - is to change backlight modes using Dynamic Lighting and try to capture that with the ACPI tool (in case dynamic lighting uses some asus endpoints)

gbassani commented 3 weeks ago

@gbassani P.S. What you can try to do - is to change backlight modes using Dynamic Lighting and try to capture that with the ACPI tool (in case dynamic lighting uses some asus endpoints)

Unfortunately, that is what I had done to generate the measly 2 rows above, for some reason it only captured the brightness change when I hit the F4 key. If I get around to it later, I'll try again with no filter just to skim the output and see if there are any lines that appear at all from the driver.

Thank you for spending the time troubleshooting.

seerge commented 3 weeks ago

@gbassani if that's the only output you see - then it means that Dynamic Lighting uses some other absolutely unknown protocol to change backlight (since asus own apps also can't change it).

Without having physical access to your device it unrealistic to reverse-engineer that unfortunately.

Also, why exactly do you want to change backlight specifically from G-Helper if you have windows native way of doing that ?

lazer15 commented 3 weeks ago

Here is a capture of pressing keyboard backlight (F4) key and the brightness keys (F5 and F6). This is on a proart P16 with cpu 370 HX. KB_BL_Monitor_BL_P16.zip

I first changed screen brightness a couple times then did the keyboard backlight up and down a few times.

I have the same issue as OP. If I stop MyAsus services I lose the ability to control screen brightness and keyboard backlight.

If I turn off the backlight then kill the asus services using ghelper, the backlight for the keyboard stays off and I can't turn it back on. If I then restart the computer, when the computer finishes rebooting, the keyboard backlight will be stuck at max brightness and breathing pattern. As far as I can tell, there is no way to set breathing or any other pattern inside myasus or anywhere else (this is my first asus laptop though so perhaps I'm not looking in the right location). To turn off the backlight, I have to restart myasus and let it "repair". Then I can turn the light off and kill asus services again (I prefer the backlight to stay off) until I reboot/shutdown the computer again.

The P16 doesn't have RGB keyboard backlighting, only white. Dynamic lighting appears to do nothing on the P16. Any option I select there doesn't cause a change in either case of having killed asus services or with those services running.

Let me know if I can help with another capture.

seerge commented 3 weeks ago

@lazer15 hello, thanks for capturing.

I don't think that your case is same as OP's. As for him it's backlight mode toggle (i.e. breathing / color-cycle, etc) that doesn't work. He can control backlight brightness (with one small tweak) and could control screen brightness from the beginning :)

For your case - it looks more like system doesn't notify G-Helper about hotkeys being pressed at all.

As in the log i see only actual hotkey commands (using 0x00100021 endpoint) and G-Helper already knows and handles them

Namely

https://github.com/seerge/g-helper/blob/8b66e95b8bd2403a11a15a697152924ad796b27b/app/AsusACPI.cs#L38

lazer15 commented 3 weeks ago

The screen brightness is changeable through the windows settings app in the display section using the native slider that is there. The myasus app doesn't have any brightness control sliders or toggles for the keyboard or monitor. I also checked the asus creator hub application but it doesn't have any brightness controls for monitor or keyboard. I don't see a way to change the keyboard backlight anywhere except with the hotkey F4.

I launched ghelper then stopped asus services. This caused the monitor brightness keys and the keyboard backlight hotkey to stop working. I then restarted ghelper. The brightness hotkeys for the monitor then started working. Keyboard backlight keys remain unresponsive. I do get the toast message popping up saying backlight off, mid, high but no physical changes to the keyboard light. p16_log.zip

seerge commented 3 weeks ago

@lazer15 my question was if you could change keyboard backlight mode (i.e static or breathing) in asus apps ?

As for for backlight brightness toggle (F4 in your case), did you try the build I was linking in this thread above ? GHelper.zip

lazer15 commented 3 weeks ago

@seerge there is no option to change backlight mode in any asus app that's preinstalled. Maybe if I install armoury crate? That's not something that comes with this model though.

I tried the ghelper version you linked. Screen brightness hotkeys work but F4 keyboard toggle doesn't work. Only the ghelper keyboard backlight messages appear when pressing F4, no actual changes.

seerge commented 3 weeks ago

@lazer15

there is no option to change backlight mode in any asus app that's preinstalled. Maybe if I install armoury crate? That's not something that comes with this model though.

Then most likely it doesn't support mode changing at all :) So obviously G-Helper won't make a difference here

I tried the ghelper version you linked. Screen brightness hotkeys work but F4 keyboard toggle doesn't work. Only the ghelper keyboard backlight messages appear when pressing F4, no actual changes.

Can you post a log from it ?

lazer15 commented 3 weeks ago

@seerge I'm only interested in changing the brightness of the keyboard light. The light patterns aren't of interest to me. Are you saying ghelper isn't able to change the keyboard brightness since this laptop model doesn't support keyboard light pattern modes? I know on startup it changes to breathing but once in windows it changes to solid. That's just how proart laptops are on boot up according to other people. test_log.zip

seerge commented 3 weeks ago

@lazer15 G-Helper should be able to change keyboard backlight level.

The log you uploaded is not from the build I linked above tho, so no wonder it doesn't work. Linking it again GHelper.zip

lazer15 commented 3 weeks ago

@seerge I deleted all the ghelper versions I had. It should be the correct version now because I have no other versions anymore. I also cleared the appdata folder for ghelper. It does still say 0.184.0 though. Should I be looking for a version number change? log.zip

seerge commented 3 weeks ago

@lazer15 hm, strange. Can you try this build ?

GHelper.zip

lazer15 commented 3 weeks ago

@seerge log.zip

seerge commented 3 weeks ago

@lazer15 ok, can you try this build instead ?

GHelper.zip

lazer15 commented 3 weeks ago

@lazer15 ok, can you try this build instead ?

GHelper.zip

@seerge It works! That one is a keeper. Brightness for both keyboard and screen are controllable with the hotkeys now. :thumbsup: Thanks!

Here's a log in case it's useful. log.zip

seerge commented 3 weeks ago

@lazer15 ok, great to hear