search

seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://g-helper.com
GNU General Public License v3.0
7.64k stars 265 forks source link

ROG Strx G15 2022 RGB Starry Night Request #3120

Closed Jeb166 closed 1 month ago

Jeb166 commented 1 month ago

Rules

Is your feature request related to a problem? Please describe

In Armoury Crate, in RGB options there was an option called "Starry Night" for G15 2022 laptop. I can't see that option in the G-Helper.

Describe the solution you'd like

If it is possible it would be great to have Starry Night option, i was using that a lot.

Describe alternatives you've considered

No response

Device and Model

Asus Strix G15 G513RM

Additional information.

No response

seerge commented 1 month ago

@Jeb166 hello, your device (G513RM) exists in 2 editions. One with per-key RGB that supports lots of RGB modes and one with more basic 4-zone RGB that doesn't support them.

Open Extra settings, you should see Per Key RGB checkbox there. Toggle it and restart app after.

Jeb166 commented 1 month ago

@Jeb166 hello, your device (G513RM) exists in 2 editions. One with per-key RGB that supports lots of RGB modes and one with more basic 4-zone RGB that doesn't support them.

Open Extra settings, you should see Per Key RGB checkbox there. Toggle it and restart app after.

I've just tried the Per Key RGB checkbox and half of the RGB modes that appears after enabling that doesn't work, including Starry Night option. It just stucks with a single color and doesn't do any animation at all.

seerge commented 1 month ago

@Jeb166 then most likely it's not supported on firmware level by your keyboard.

Do you have per-key RGB ? Could you set individual colors for each key in AC? How did that Starry Night look when you set it in AC and did you have to toggle Aura Sync for it to work ?

Jeb166 commented 1 month ago

Do you have per-key RGB ? Could you set individual colors for each key in AC?

I am really sorry, i forgot to talk about that. It's just 4 zones, not per key unfortunately. I also have a 4 zone under light which i could set independent from the keyboard zones. So i can say 8 zones total.

How did that Starry Night look when you set it in AC and did you have to toggle Aura Sync for it to work ?

I was able to select two colors, and the system would randomly alternate between them across eight different zones independently. It didn't require Aura Sync to function.

seerge commented 1 month ago

@Jeb166 well, then it's strange, cause all possible hardware modes are already listed (they are literally numbered by IDs, so I doubt it's more). So if "new" modes after checking option under Extra do nothing i don't know how that starry night worked in AC

https://github.com/seerge/g-helper/blob/5e51511df01dcb1845847356eb6b68b9d1f7eabd/app/USB/Aura.cs#L38

Can you set this mode using https://openrgb.org/ ?

Jeb166 commented 1 month ago

Can you set this mode using https://openrgb.org/ ?

I tried OpenRGB just now but the layout of the zones in that app is completely wrong, right side of the device is considered as keyboard and the left side is the lightbar. Also i didn't understand, what is "public enum AuraMode : int "? Do i need to set it in the OpenRGB? How can i do it? I can't find a console or terminal for that.

Edit: Also choosing the "Starry Night" option does nothing in OpenRGB. When i choose apply after choosing Starry Night it just resets back to Direct mode.

seerge commented 1 month ago

@Jeb166 ok. Most likely AC just imitates this "mode" on software level (i.e. it manually adjusts colors few times a second for each zone)

We can check how exactly it happens by capturing actual payload AC sends to the device

Posting a guide on how to capture (from other thread)

Install trial from https://www.hhdsoftware.com/device-monitoring-studio (will require reboot)

  1. Start AC and disable Aura Sync there

  2. Launch Monitoring Studio, pick Asus device with Product ID 0x19B6 from the list and double click on it Screenshot 2024-01-20 163125

  3. Add Packet View to Procesing and click Start Screenshot 2024-01-20 163136

  4. Open AC and turn ON Starry Night mode there

  5. Check if Monitoring Studio catching data. If NOT - you probably have selected wrong Asus device on step 2 (so need to re-do it)

  6. In Monitoring Studio select Tools -> Save to Log, and save data Screenshot 2024-01-20 163247

Upload this data here.

Thanks

Constrat commented 1 month ago

I tried OpenRGB just now but the layout of the zones in that app is completely wrong, right side of the device is considered as keyboard and the left side is the lightbar. Also i didn't understand, what is "public enum AuraMode : int "? Do i need to set it in the OpenRGB? How can i do it? I can't find a console or terminal for that.

Regarding this I've been working with the ORGB team and with the 1.0 update, a fix for the G15 and G17 devices should come. If you want to try (experimental) this is a build with the latest changes regarding the implementation of the Asus KLM etc etc https://gitlab.com/CalcProgrammer1/OpenRGB/-/jobs/7828735112/artifacts/download?file_type=archive (Windows x64 build).

You mentioned you probably don't have per key RGB, but at least with this build the layout should be fairly correct (unless the per-key completely brakes everything. I hope not :)

Jeb166 commented 1 month ago

@seerge I apologize for keeping you waiting, thank you for your support. I will install AC again and send you the log data. @Constrat Thank you. I am going try it and return feedback.

Jeb166 commented 1 month ago

Okay i realized i actually need to turn on Aura Sync to see Starry Night option, sorry for being dumb. Should i still need to send you to the data?

Jeb166 commented 1 month ago

Saved the data to a log file but can't locate it, where is it exactly?

Found it: starry_night_log.zip

seerge commented 1 month ago

@Jeb166 ok, great. Thanks.

But as I expected there is no such thing as hardware / firmware "Starry Night" in a keyboard. That's why I was asking if you had to enable Aura Sync in order to make it work in a first place

What AC does in this case - is just manually sets colors for each zone few times a second, imitating this animation.

On this stage G-Helper doesn't do this things (with the only exception of Ambient mode, and even there it's quit simplified). Main reason is cause it's quite resource heavy. And next to that I simply don't have a single RGB-device where I can experiment with this :))

Jeb166 commented 1 month ago

@Jeb166 ok, great. Thanks.

But as I expected there is no such thing as hardware / firmware "Starry Night" in a keyboard. That's why I was asking if you had to enable Aura Sync in order to make it work in a first place

What AC does in this case - is just manually sets colors for each zone few times a second, imitating this animation.

Oh i just understood how it works, thank you.

On this stage G-Helper doesn't do this things (with the only exception of Ambient mode, and even there it's quit simplified). Main reason is cause it's quite resource heavy. And next to that I simply don't have a single RGB-device where I can experiment with this :))

If it’s going to make it more resource-heavy, it’s better this way. The reason I chose G-Helper over Armoury Crate is because of how lightweight it is. I want to thank you for this amazing software and your support. Have a nice day!

seerge commented 1 month ago

@Jeb166 ok, great.

Then I'm afraid (on this stage) i'm simply not able to recreate any "dynamic" modes in G-Helper. May be somewhere in the future, if i will find a way to do it lightly and get my hands on a device with RGB as well.

Therefore closing this as not planned for now.

Thanks and sorry.