seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://seerge.github.io/g-helper/
GNU General Public License v3.0
7.21k stars 261 forks source link

Add "Not now"/"Remind me later" button to update dialog and rename "No" to "Skip version" #3208

Open tonweg15 opened 4 hours ago

tonweg15 commented 4 hours ago

Rules

Is your feature request related to a problem? Please describe

Sometimes, when I start G-Helper, there is an update available, but even though the update process is really fast, I don't want to update right now for one reason or another, but I still might want to update later and not skip the update altogether. But when I then click on No, a skip_version entry is added to the config file and on subsequent starts, the update dialog is therefore no longer displayed.

Describe the solution you'd like

Instead of there only being a Yes and No option (which is also kinda misleading, since it doesn't only not update, it also skips that version altogether), there would be Yes, Skip version and Not now or Remind me later. The behaviour for Yes and Skip version would be unchanged, Not now or Remind me later would simply close the windows and not update or add anything to the config file.

Describe alternatives you've considered

Device and Model

Flow X13 2022 GV301RE, XG Mobile 6850XT

Additional information.

No response

seerge commented 3 hours ago

@tonweg15 hello.

I can add that, but i'm not sure if it's worth to overcomplicate process here.

What are the downsides of updating straight away ? It's an (almost) instant process. App just downloads zip with new version from github, and unpacks it over old one.

Also manually replacing old exe with new one does not affect any admin permissions. Startup task pointing to exe remains same, and if was running app as admin on logon before - it will keep doing that.