seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://seerge.github.io/g-helper/
GNU General Public License v3.0
7.51k stars 266 forks source link

Anime Matrix general position #3304

Open joex92 opened 1 day ago

joex92 commented 1 day ago

Rules

Is your feature request related to a problem? Please describe

All the modes but Picture/GIF mode are set in place, and sometimes, in case of clock mode, it´s not centered (this was an issue too on AC) depending on the date or time, so sometimes a bit of the clock is not seen, it's not unreadable thou...

Describe the solution you'd like

Being able to "move" the clock or the audio visualizer to place it or scale it (I believe moving it is easier) or even rotate it. this could work with the logo too and any other future mode added.

It would be redundant for Picture/GIF mode thou...

Describe alternatives you've considered

none

Device and Model

Asus ROG Zephyrus G14 GA401QC

Additional information.

No response

seerge commented 1 day ago

@joex92 hello,

By default picture is aligned to top-right corner of the matrix and scaled to fit to it completely (i.e. by 100% height or width), but you can already pan / resize them under Picture settings.

As for clock - it should be centered already, can you make a photo of how it looks in your case ?

joex92 commented 1 day ago

@seerge Hi,

this is how it looks: WhatsApp Image 2024-10-26 at 13 35 37_2a84ad43 it´s not unreadable, but as you can see there's a little portion of the clock that is "outside of bounds"...

also it would be great for it to not be diagonal, or to move it a bit and scale it... that's why I'm suggesting it as a general position setting, it would be redundant for the Picture Mode, but the purpose would be for the other modes...

In case of the Audio VIsualizer, it would be cool to move it a bit up or to put it diagonally, etc. WhatsApp Image 2024-10-26 at 13 38 57_5bcf3b90

joex92 commented 1 day ago

I would suggest as well that the "Picture/Gif" button be changed to "Settings" (meaning it's the selected mode settings), and depending on the mode it would be clickable or not... it's confusing to be able to open that setting while not using the picture/gif mode...

seerge commented 1 day ago

@joex92 try this build, it should adjust clock row a bit (you have 2021 model and there matrix is a bit smaller than on 2022 where I was fitting it)

GHelper.zip

I can rename Picture/GIF button to something else when that screen will contain more settings for other modes, atm everything there is related only to Picture

And can't really want to move Audio mode bars higher. Currently they would hit edge of the matrix when certain bar is 100% high (i.e. when corresponding frequency has maximal volume)