seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://g-helper.com
GNU General Public License v3.0
7.63k stars 265 forks source link

sRGB Color Gamut Clamp and Modern Standby Assist #520

Closed ModrnJosh closed 8 months ago

ModrnJosh commented 1 year ago

Hey there, as you might know, 2023 Asus ROG laptops now have an sRGB color gamut clamp (in GameVisual) which is extremely useful for creators not working in color-managed applications, or just people who don't like the wide-color-gamut look in Windows, so that you can more accurately reproduce sRGB.

Another new feature in 2023 Asus laptops is Modern Standby Assistant. This one I'm not sure how Asus makes it work, but basically it fixes the Modern Standby issue in which many laptops suffer from waking up, overheating, or running fans when they're supposed to be sleeping.

Would love if there were a way to implement/toggle these features in G-Helper! I would be happy to volunteer in pulling any code/ACPI stuff or whatever to assist as I have a 2023 Zephyrus G14.

seerge commented 8 months ago

Now we need to build a database of color profiles, as it won't work w/o them.

nathancdy commented 8 months ago

@seerge I still have my 2022 G14 at the moment, I could send you my files when I get home?

I dont remember if it has the Gamut options though for that model. (sRGB, P3, etc). Are the GameVisual filters (Racing, RPG, etc) global filters for all ROG models or are they still model-specific?

seerge commented 8 months ago

@nathancdy there are no gamuts on 2022 model. Only main profile that gives you access to GamVisuals. 2023+ devices have gamuts

ModrnJosh commented 8 months ago

@seerge Seems to be working here as well! I can send over files for the 2024 G16 and G14

THEBOSS619 commented 8 months ago

Just to help others, I have this one which allows me to have Dolby Vision and also view HDR content correctly. I got ASUS ROG Strix G16 2023 [Intel i7 13650hx with Nvidia 4060] with a display of FHD at 165Hz. image color-Dolby Vision-g614jv.zip

seerge commented 8 months ago

@THEBOSS619 that's cool, but it's just a dolby app that you can download and install on any asus laptop from Microsoft Store :) I also have this. It applies only to dolby vision content (i.e. to videos on netflix or so as far as I know)

THEBOSS619 commented 8 months ago

@THEBOSS619 that's cool, but it's just a dolby app that you can download and install on any asus laptop from Microsoft Store :) I also have this. It applies only to dolby vision content (i.e. to videos on netflix or so as far as I know)

Although it is true for a small part about downloading Dolby app to any ASUS laptop... but you won't have Dolby vision option without having the files that I have uploaded previously :) for example... here is Dolby app without the required files looks like... image

As you can see... no Dolby vision option available and Dolby vision won't work. You must have the files that is made specifically for your laptop model & screen model to get a functional Dolby vision.

You can get it working not just through Netflix... but also through potplayer (with proper settings to work) and obviously it will work with windows default built-in media player and it will tell you a small icon on top that Dolby vision is working whenever you start a any MP4 DV video file.

Also i would like to add here is the gamevisual according to my laptop model & spec :) GameVisual.zip

seerge commented 8 months ago

@THEBOSS619 i did a clean windows reinstall, and by just getting official Dolby Atmos Driver from asus website (or Updates section in G-helper) it unlocks that for me too

Screenshot 2024-03-08 190716

THEBOSS619 commented 8 months ago

@THEBOSS619 i did a clean windows reinstall, and by just getting official Dolby Atmos Driver from asus website (or Updates section in G-helper) it unlocks that for me too

Screenshot 2024-03-08 190716

@seerge lucky you... we as G16 users don't have it as a download option... the only way to obtain the files is you need to download the whole Armoury Crate app with all it's bloat to get it... here's what G-helper shows.. it only gives you Audio driver file for Dolby atmos... but there is no Dolby vision files.. image

I have searched the whole website and also the whole g-helper update list... no Dolby vision file to get it.

seerge commented 8 months ago

@THEBOSS619 for me it's same, DolyAtmosDriver unlocks all features of the Dolby app, including Vision :)

THEBOSS619 commented 8 months ago

@THEBOSS619 for me it's same, DolyAtmosDriver unlocks all features of the Dolby app, including Vision :)

@seerge I know, I already checked your model on asus website but for all ASUS ROG Strix 2023 & after models.. they don't have it at all, they only included Dolby Atmos but no Dolby vision. So who ever cleaned installed windows they won't be able to get Dolby vision working unless you install Armoury Crate which is absured.

What I did is I made full image backup of windows then installed Armoury Crate and got the files I needed for gamevisual & Dolby vision and then restored my backup so that I have a peace of mind of not having Armoury Crate left overs file on system folders.

It's ASUS's fault for not providing it separately and forcing us to get it from Armoury Crate. The same logic for GameVisual... they don't allow you to download it separately and you are forced to get from Armoury Crate :)

Also i would like to add... when I use AutoHDR or by other name [Auto color management] , Armoury Crate doesn't allow you to use Gamevisual option until you turn off AutoHDR or by other name [Auto color management]

but thanks to G-Helper... i am able to use Gamevisual from G-Helper without turning off AutoHDR or by other name [Auto color management] which is AMAZING!!!

I am thankful for your amazing work 🙏

AudreyAP commented 8 months ago

All you need to re-enable Dolby vision is the pqconfig.dv file from your color folder. Back it up before clean installing. You can also recover it by doing a cloud recovery from BIOS.

seerge commented 8 months ago

Ok, since Color Gamuts and Visual Modes are live in last release, closing this as completed

seerge commented 8 months ago

@AudreyAP @THEBOSS619 @nathancdy @ModrnJosh

One small update (will be also included in next release)

I have added a button in the app that will download and install (into GameVisual folder) all your ICM profiles automatically.

Button is visible only when your C:\ProgramData\ASUS\GameVisual folder is empty or doesn't exist at all (i.e. clean Windows install). So if you want to test how it works, delete that folder completely (back it up first) and run the app

GHelper.zip

P.S. @THEBOSS619 I have noticed that when app sets any of the visual modes using Splendid utility, that utility recreates PQConfig.dv (needed for DolbyVision), so you may try your luck

THEBOSS619 commented 8 months ago

@AudreyAP @THEBOSS619 @nathancdy @ModrnJosh

One small update (will be also included in next release)

I have added a button in the app that will download and install (into GameVisual folder) all your ICM profiles automatically.

Button is visible only when your C:\ProgramData\ASUS\GameVisual folder is empty or doesn't exist at all (i.e. clean Windows install). So if you want to test how it works, delete that folder completely (back it up first) and run the app

GHelper.zip

P.S. @THEBOSS619 I have noticed that when app sets any of the visual modes using Splendid utility, that utility recreates PQConfig.dv (needed for DolbyVision), so you may try your luck

Thank you, I have tried your build and it works! I pressed Download color profiles and it downloaded all the required files correctly! This is how it looks after pressing download the color profiles button... image image

Unfortunately Splendid utility isn't available for G16... I have checked multiple times through asus website https://rog.asus.com/laptops/rog-strix/rog-strix-g16-2023-series/helpdesk_download/

seerge commented 8 months ago

@THEBOSS619 splendid utility is already installed on your device as part of Asus System Control Interface :) g-helper runs it to set gamuts / visual modes by using this color profiles

THEBOSS619 commented 8 months ago

@THEBOSS619 splendid utility is already installed on your device as part of Asus System Control Interface :) g-helper runs it to set gamuts / visual modes by using this color profiles

@seerge Oh I see what you mean, makes sense ! I have deleted PQConfig.dv and tried to switch Visual Modes... tested different kind of combinations. unfortunately it doesn't recreate PQConfig.dv file

MaxLebled commented 8 months ago

Hi! Just got around to checking this out... this works great, thank you!

I have ONE issue with it, however... when the nVidia dGPU is driving the screen (advanced optimus or Ultimate mode), I'm using another software (novideo_srgb) to work around a black crush bug, and do sRGB gamut clamping that is more accurate and better dithered than the stock profiles.

Unfortunately, the gamut setting is shared by both video adapters, so this is a minor regression for me. Not a dramatic one, it's not that much of a hassle to set the gamut back to Native when I also toggle Ultimate mode on... but it might be nice to let the gamut be remembered on a per-adapter basis?

seerge commented 8 months ago

@MaxLebled G-Helper uses "AsusSplendid" app (from Asus Control Interface "driver") to set those things (you can see calls in an app log), so it's a bit out of control to be honest.

But I have observed pretty much opposite situation on G14 2024 (AMD / NVidia)

When I change from Eco / Optimus to NVidia Only / Ultimate - video profile resets! It even has separate OLED dimming setting (which also works via Splendid)

Are you sure it's same ? Btw, is Asus'es sRGB worser than novideo_srgb? (i encountered that app ,when was researching how to modify ICC profiles ...)

MaxLebled commented 8 months ago

The sRGB profile has a slightly warmer color temperature, slightly brighter shadows. And without the novideo_srgb app, doesn't dodge the black crush bug or do nicer dithering.

I can see that darker grays are ever so slightly pinkish when using the sRGB profile with the iGPU for example.

Not a big deal though!

seerge commented 8 months ago

@MaxLebled oke, cause color temp cam be also adjusted (there is a dropdown in the app now) , i have added only few presets, but if needed actual value is set in a range from 0 to 100 (50 is neutral), so it allows some fine-tuning.

seerge commented 8 months ago

@MaxLebled you can try to replace AsusSRGB profile in C:\ProgramData\ASUS\Gamevisual with your custom one. For Splendid app it doesn't matter, it picks file by name :)

NickProkoArt commented 8 months ago

Hello! By the way, another way for those who have an AMD video card (discrete or integrated) to enable sRGB clamp is through the AMD driver. (I have Adrenalin Edition installed) Here is a link to where the switch is in the app: https://pcmonitors.info/articles/taming-the-wide-gamut-using-srgb-emulation/ There is also a way to do this through the driver for nvidia. Maybe this will be interesting to someone. But inside Ghelper it is much more convenient.

seerge commented 8 months ago

@blackgold9 thanks for the tip :) that's what I was suggesting in FAQ (for visual modes) before this new thing got implemented.

NickProkoArt commented 8 months ago

@seerge Profiles that are downloaded at the click of a button. Are they universal? I have ROG Strix SCAR 17 (2023)

seerge commented 8 months ago

@NickProkoArt they are specific for each model code (pack contains all possible profiles for different panels you model can have).

AsusSplendid utility that sets / uses them knows which one to use based on your panel

NickProkoArt commented 7 months ago

@seerge Hello! To disable/restore the color profile to its original state (after installing color profiles in the game visual folder) Should I simply delete the GameVisual folder and also the profile in Windows color management? (For my model, although it is a 2023 model, there is no gamut clamp :( ) For some applications, if I change the window size, a one-time flicker appears. I had the same thing when ArmoryCrate was installed...

seerge commented 7 months ago

@NickProkoArt just Windows Color Profile is enough, GameVisual folder is used only by AsusSplendid.exe itself, it's not related to system anyhow

Nic0laus commented 7 months ago

Hi, so I have 2022 G14 and do I understand correctly that the color gamut is controlled by AC and is only supported in newer models? A while ago I was trying to match laptop panel with my monitor, but couldn't get it due to laptop screen always being in DCIP3 mode and I wasn't able to change it anywhere. An option to somehow force it into going in sRGB mode would be great (of course still having proper color reproduction)

seerge commented 7 months ago

@Nic0laus it is not controlled by AC, but by special Asus utility. To be able to set sRGB you need a correct color profile for your panel. 2022 model doesn't have that