search

seerge / g-helper

Lightweight Armoury Crate alternative for Asus laptops and ROG Ally. Control tool for ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, TUF, Strix, Scar and other models
https://seerge.github.io/g-helper/
GNU General Public License v3.0
7.06k stars 256 forks source link

[Bug] The Battery charge limit doesn't work if the user is not logged in yet #658

Closed ke1ne closed 1 year ago

ke1ne commented 1 year ago

Describe the bug The Battery charge limit doesn't apply when the laptop is just turned on but the user is not logged in yet.

Clear scenario to Reproduce

  1. Turn the laptop on.
  2. The Log In dialog appears.
  3. Do nothing.
  4. The laptop battery is charging over the limit set (60%).

Expected behavior Enable the battery charge limit after Windows loaded before the user logged in

Desktop (please complete the following information):

Asus software Software uninstalled and services disabled via G-Helper debloat.

seerge commented 1 year ago

Then probably your hardware doesn't remember settings after reboot. As soon as app is started - it will set a new limit anyway, before that it obviously can't set anything as it's not running :)

What do you expect me to do here? :)

seerge commented 1 year ago

@ke1ne P.S. On a side note - do you have fast boost enabled in bios ? it could be that if not, it will reset all hardware settings each reboot. Try to swtich it off/on

ke1ne commented 1 year ago

Then probably your hardware doesn't remember settings after reboot. As soon as app is started - it will set a new limit anyway, before that it obviously can't set anything as it's not running :)

This didn't happen previously, so that's why I become curious. I've changed nothing in BIOS or system globally.

P.S. Also, now G-Helper sometimes don't start automatically, and this happens kind of randomly, with no errors in logs.

UPD. I have fast boost enabled, and didn't touch it previously. After a couple of re-launches of app with forced admin permissions, and re-adding to autostart using its default checkbox, it seems to be OK. Have no idea why it failed.

What do you expect me to do here? :)

Personally from you I'm expecting nothing specific; the issue reporting is a usual thing for public projects, and my question was also addressed to the community. You did a GIANT work, and there is no signs to consider my question as any kind of forcing or pushing.

Thank you very much!

seerge commented 1 year ago

@ke1ne well, as for charge limit : in general it should be remembered by hardware (i.e. when laptop is completely off - it shouldn't charge above limit as well). But I can imagine that sometimes hardware glitches / resets it.

G-Helper can't start before login due to way it's done (it's a windows app, that stays in tray) and not a windows service :) So it's not much can be done here unless I will split g-helper into 2 pieces ( service + control app) but that's sort of against of a logic of being lightweight and easy to use :)

So for now it will stay as is.

nirexnova111 commented 2 months ago

@seerge Hey my asus rog zephyrus battery says charging but its stuck at 19% , if i remove the power cord laptop turns off any idea whats the issue